Fix blockly comment text color #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently blockly comments have the colors background:
#FFCand font:#555. Technically these colors pass accessibility tests, but it can still be hard to read.By default blockly comments are supposed to have a font color of
#000. AI's comments did not because the designer css was overflowing into the Blockly workspace.This PR changes the comment text color back to the default
#000.Testing
(open the image in a new tab for a better reference).
I also inspected the textarea element to ensure the font color was being applied.
Additional Information
This was originally discussed in the comments of this forum post.