Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Preview #764

Closed
wants to merge 8 commits into from
Closed

Media Preview #764

wants to merge 8 commits into from

Conversation

@aaosuarez
Copy link
Contributor

@aaosuarez aaosuarez commented May 3, 2016

6.UAP Project: Media Usability
Created new "Preview" option in Media list to allow users to preview their files. Currently support .png, .jpg, .gif, .bmp, .mp3, .wav, .ogg, .mp4, and .webm for major browsers if they support them. Fallback messages for other file types and browsers that don't support the displaying the file types listed.
@halatmit @afmckinney @jisqyv

aaosuarez and others added 6 commits Apr 19, 2016
One Language (and only Chrome) and add “GO” button to emulator
starting buttons. Also use the "std" GWT linker

Change-Id: I6fa147ccd86f5ab7215331153643f037c0ba902e
This reverts commit 565f492.
@josmas
Copy link
Member

@josmas josmas commented May 3, 2016

@a-suarez any chance you can push this and #763 to appspot for people to see it in action before reviewing?

@halatmit
Copy link
Contributor

@halatmit halatmit commented May 3, 2016

Thanks. are you still planning to graduate? ;)

== Hal Abelson
hal@mit.edu
Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.

On Tue, May 3, 2016 at 11:40 AM, Aaron Suarez notifications@github.com
wrote:

6.UAP Project: Media Usability
Created new "Preview" option in Media list to allow users to preview their
files. Currently support .png, .jpg, .gif, .bmp, .mp3, .wav, .ogg, .mp4,
and .webm for major browsers if they support them. Fallback messages for
other file types and browsers that don't support the displaying the file
types listed.
@halatmit https://github.com/halatmit @afmckinney

https://github.com/afmckinney @jisqyv https://github.com/jisqyv

You can view, comment on, or merge this pull request online at:

#764
Commit Summary

  • Created preview file command in context menu of asset list
  • Special Debug Hack
  • Reverting spacing for file
  • Added identification for all supported file types. Allow file
    previews for those supported by major browsers.
  • Code cleanup and additional usability improvements to interactions
    with AssetList
  • Revert "Special Debug Hack"

File Changes

Patch Links:


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#764

import com.google.gwt.user.client.ui.Tree;
import com.google.gwt.user.client.ui.TreeItem;
import com.google.gwt.user.client.ui.VerticalPanel;
import com.google.gwt.user.client.ui.*;

This comment has been minimized.

@jisqyv

jisqyv May 3, 2016
Member

Please eliminate the * based import and replace it with explicit imports.

@jisqyv
Copy link
Member

@jisqyv jisqyv commented May 17, 2016

Looking good. I'll run some tests and if all is well I'll give it a thumbs up and merge (but I do need to test :-) ).

@afmckinney afmckinney assigned afmckinney and unassigned jisqyv May 24, 2016
@afmckinney
Copy link
Contributor

@afmckinney afmckinney commented May 24, 2016

Tested but need to handle a few conner cases I'll fix and move to gerrit.

@afmckinney afmckinney added this to the Hot List (AFM) milestone Dec 7, 2016
Copy link
Member

@barreeeiroo barreeeiroo left a comment

It's just an amazing feature, and works as it should 👍

Copy link
Member

@ewpatton ewpatton left a comment

LGTM

@ewpatton
Copy link
Member

@ewpatton ewpatton commented Sep 9, 2019

Note that because the branch no longer exists, I've manually merged this as fc2a232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants