support Tensor input to make_tuple #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhijian-liu
approved these changes
Jun 22, 2021
Contributor
zhijian-liu
left a comment
zhijian-liu
left a comment
There was a problem hiding this comment.
Thanks! This has actually been fixed in #81. However, as that PR still requires some time before merging, we can first apply this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the type annotation,
tensor_stridecan be a Tensor: https://github.com/mit-han-lab/torchsparse/blob/master/torchsparse/utils/kernel.py#L21But
make_tuplefails silently (returns None) with Tensor input. This adds an elif branch for make_tuple from Tensor.Not extensively tested -- it is possible that some other code will break if it relies on the None output here.