Skip to content

Conversation

@ashafq
Copy link
Contributor

@ashafq ashafq commented Aug 13, 2015

Using Arch Linux 4.1.4-1-ARCH and gcc version 5.2.0. I got this error on build:

gcc -Werror -Wall -o mkfs mkfs.c
mkfs.c:14:0: error: "static_assert" redefined [-Werror]
 #define static_assert(a, b) do { switch (0) case 0: case (a): ; } while (0)
 ^
In file included from mkfs.c:6:0:
/usr/include/assert.h:118:0: note: this is the location of the previous definition
 # define static_assert _Static_assert
 ^
cc1: all warnings being treated as errors

I hope this fixes it.

@kaashoek kaashoek merged commit 4f2d381 into mit-pdos:master Aug 18, 2015
@kaashoek
Copy link
Member

Thanks. I applied it.

On Wed, Aug 12, 2015 at 10:17 PM, Ayan Shafqat notifications@github.com
wrote:

Using Arch Linux 4.1.4-1-ARCH and gcc version 5.2.0. I got this error on
build:

gcc -Werror -Wall -o mkfs mkfs.c
mkfs.c:14:0: error: "static_assert" redefined [-Werror]
#define static_assert(a, b) do { switch (0) case 0: case (a): ; } while (0)
^
In file included from mkfs.c:6:0:
/usr/include/assert.h:118:0: note: this is the location of the previous definition

define static_assert _Static_assert

^
cc1: all warnings being treated as errors

I hope this fixes it.

You can view, comment on, or merge this pull request online at:

#1
Commit Summary

  • Fixed broken build on Arch Linux

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1.

jafemm added a commit to jafemm/xv6-public that referenced this pull request Jun 15, 2019
iambrj added a commit to iambrj/xv6-public that referenced this pull request Oct 23, 2020
iambrj added a commit to iambrj/xv6-public that referenced this pull request Oct 23, 2020
nikhilbhave9 added a commit to soham-bagchi-ug22/xv6-public that referenced this pull request Apr 4, 2021
davidsaOpenu pushed a commit to davidsaOpenu/xv6 that referenced this pull request Jun 14, 2023
Added io.stat interface file for cgroups which gives info of what IO
devices attached to the current cgroup.
Lines are keyed by $MAJ:$MIN device numbers and not ordered.
	The following nested keys are defined.

	  ======	===================
	  rbytes	Bytes read
	  wbytes	Bytes written
	  rios		Number of read IOs
	  wios		Number of write IOs
	  ======	===================
An example of the output when reading io.stat file:
8:16 rbytes=1459200 wbytes=314773504 rios=192 wios=353

In addition to the major change a header circular dependency have beed
resolved in file.h and cgroup.h.

Note mit-pdos#1: For now we have only TTY IO devices which are connected to the
console (a hardware interface). For future IO devices this might come in
handy.
Note mit-pdos#2: The interface file is not read-only although it should be.

Note mit-pdos#3: Correct minor bugs in io.stat feature

   - Removed all the inode references in the cgroup IO functions. We don't
     use inodes now to get minor/major numbers now.

   - Renamed dev_state structure to dev_stat to indicate that it stores
     statistics.

   - Added test for io.stat feature in expect test script

   - Fixed minor issues which resulted in bugs in corner cases (for
     example, when destroying a cgroup)

Change-Id: Iba88fce5fcd96e1ea200550440a3020c35d34eaf
kyrolloszakaria added a commit to kyrolloszakaria/xv6-public that referenced this pull request Feb 27, 2024
RizzZero added a commit to sarvvnaz/xv6-public that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants