Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twine viewer #171

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Nov 23, 2016

This adds a new page that shows viewing a Twine story (exported as JSON with twison). It logs choices the user makes to the server.

This also factors out components for FeedbackForm and ResponsiveFrame from DemoPage so they can be re-used here, and adds some minimal tests.

screen shot 2016-11-23 at 12 11 37 pm

screen shot 2016-11-23 at 12 11 42 pm

screen shot 2016-11-23 at 12 11 48 pm

screen shot 2016-11-23 at 12 13 47 pm

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Nov 23, 2016

This includes an additional commit that addresses separate dependency issues that came up in the build: https://travis-ci.org/mit-teaching-systems-lab/threeflows/builds/178364383.

This happened because this is the first build pulling in React 15.4, which did a hard cutover for react-dom (facebook/react#8303 (comment)). This affected many other packages:

Most of these have been addressed upstream, but react-mini-router involved forking. In the process of cleaning up dependencies, I also addressed deprecation warnings for node-uuid which is swapped to uuid now, and removed react-audio-recorder which isn't in use anymore.

@kevinrobinson
Copy link
Contributor Author

selfie

image

@kevinrobinson kevinrobinson merged commit 8eb9536 into mit-teaching-systems-lab:master Nov 23, 2016
@kevinrobinson kevinrobinson deleted the feature/twine-scenario branch November 23, 2016 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant