Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable writing headers #19

Merged
merged 1 commit into from Nov 8, 2020

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Oct 12, 2020

This option prevents metrics from being written in the corresponding
header of the response.

This is useful to collect the metrics all the time but have a setting to
actually write it in the answer. For instance, this is desirable for
miniflux/v2#806

This option prevents metrics from being written in the corresponding
header of the response.

This is useful to collect the metrics all the time but have a setting to
actually write it in the answer. For instance, this is desirable for
miniflux/v2#806
@cljoly
Copy link
Contributor Author

cljoly commented Nov 7, 2020

@mitchellh ping (in case the notification got lost) :-)

Copy link
Owner

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! Sorry I did lose this in my inbox.

@mitchellh mitchellh merged commit feb680a into mitchellh:master Nov 8, 2020
@cljoly
Copy link
Contributor Author

cljoly commented Nov 8, 2020

Awesome, thanks!

@cljoly cljoly deleted the disable-headers branch November 8, 2020 09:24
@cljoly
Copy link
Contributor Author

cljoly commented Nov 10, 2020

@mitchellh could you please consider tagging a commit with this functionality to ease use in other projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants