This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Add option to disable writing headers - #19
Merged
Conversation
This option prevents metrics from being written in the corresponding header of the response. This is useful to collect the metrics all the time but have a setting to actually write it in the answer. For instance, this is desirable for miniflux/v2#806
Contributor
Author
|
@mitchellh ping (in case the notification got lost) :-) |
mitchellh
approved these changes
Nov 8, 2020
mitchellh
left a comment
mitchellh
left a comment
Owner
There was a problem hiding this comment.
Looks great. Thanks! Sorry I did lose this in my inbox.
Contributor
Author
|
Awesome, thanks! |
Contributor
Author
|
@mitchellh could you please consider tagging a commit with this functionality to ease use in other projects? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option prevents metrics from being written in the corresponding
header of the response.
This is useful to collect the metrics all the time but have a setting to
actually write it in the answer. For instance, this is desirable for
miniflux/v2#806