Update Platforms to Go 1.10 #96
Conversation
|
Related to #93 - I was maintaining this in a fork... but as upstream is now active (and has CI 🎉 ) I thought I'd open a PR here! |
|
This is a cleanup I wanted to see. Since a couple variables are removed I'm going to give this a good once over and triple check everything. |
|
FYI, I'm going to wait until after the holidays to merge this. Don't want to accidentally break something for someone right now. I didn't forget about it. |
|
@mattfarina Small ping on this one ;-) |
|
Curious to know, when this will get merged? |
|
I wonder if this PR needs now an update with #107 merged and 1.10 out? @mitchellh Could you have a look at this PR? It would be really great if |
|
@ruflin @mitchellh Also, support for s390x |
This adds all platforms up to Go 1.9 Tests are updated to support Go versions > 1.5 The OsList and ArchList variables are removed as they appear unused Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
This commit adds support for Go 1.10 No new platforms were added this release It also adds a PlatformLatest variable to make it easier to update the latest version in places where it is returned by default. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
|
Thanks this looks great! Thank you so much. Once the tests pass I'll merge this. |
|
Thanks a lot @dave-tucker @mitchellh @mattfarina |
With mitchellh/gox#96 gox has been update to support all the platforms for 1.10. Instead of depending on our self defined list as default this changes to dependn on gox defaults. The difference on platforms built by default looks as following: Removed: ``` --> linux/ppc64: github.com/elastic/beats/filebeat --> linux/ppc64le: github.com/elastic/beats/filebeat --> linux/arm64: github.com/elastic/beats/filebeat ``` Added: ``` --> darwin/386: github.com/elastic/beats/filebeat ``` It's still possible as before to overwrite these defaults in each Beat. The gox platforms depend on the go version used. Because of this updating the Go version on our side could bring new platforms. But as we version the go version as part of the repo we would detect this directly. Having said that, recently not new platforms have been added. This PR also changes the defaults for Filebeat to depend on the gox defaults.
|
Thanks.. This also covers #85 |
This adds all platforms up to Go 1.9
Tests are updated to support Go versions > 1.5
The OsList and ArchList variables are removed as they appear unused
Signed-off-by: Dave Tucker dave@dtucker.co.uk