Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete key from unused map if field value cannot be set #150

Merged
merged 1 commit into from Mar 20, 2020
Merged

Do not delete key from unused map if field value cannot be set #150

merged 1 commit into from Mar 20, 2020

Conversation

@mback2k
Copy link
Contributor

@mback2k mback2k commented Dec 16, 2018

Track unusable keys in case the value cannot be set. This helps troubleshoot issues in case a struct was unexported. It took me over a hour to find such an issue once, I would like to avoid this in the future.

@mitchellh
Copy link
Owner

@mitchellh mitchellh commented Mar 18, 2020

Hi, its been over a year so I apologize but if you're interested in this I'd love to see a test case added here.

@mback2k
Copy link
Contributor Author

@mback2k mback2k commented Mar 19, 2020

Thanks for your response, I just rebased and force-pushed my change, added a new test and updated existing metadata tests to include an unexported field. Please take a look.

@mitchellh
Copy link
Owner

@mitchellh mitchellh commented Mar 20, 2020

Perfect. Thank you!

@mitchellh mitchellh merged commit 330a4f5 into mitchellh:master Mar 20, 2020
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants