Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decodeMapFromStruct: Only deref element if we're squashing the struct #232

Merged
merged 1 commit into from Jan 12, 2021

Conversation

@mitchellh
Copy link
Owner

@mitchellh mitchellh commented Jan 12, 2021

Fixes #231

This also reverts the test change that was introduced in 231 back to
the original test. This retains the new tests added in 231 to verify
the behavior of 231.

cc @dnephin

},
"Vfoo": "",
},
"omittable-nested": &Nested{},

This comment has been minimized.

@mitchellh

mitchellh Jan 12, 2021
Author Owner

This is just reverting the change in #205 back to what the test originally was.

Fixes #231

This also reverts the test _change_ that was introduced in 231 back to
the original test. This retains the _new tests_ added in 231 to verify
the behavior of 231.
Copy link
Contributor

@dnephin dnephin left a comment

Nice! LGTM, thank you for fixing!

I'll give it another try with Consul test suite tomorrow, but I'm pretty sure this will fix it.

@mitchellh mitchellh merged commit 18a713d into master Jan 12, 2021
2 checks passed
2 checks passed
@github-actions
test (1.15.x, ubuntu-latest)
Details
@github-actions
test (1.15.x, ubuntu-latest)
Details
@mitchellh mitchellh deleted the issue-231 branch Jan 12, 2021
@dnephin
Copy link
Contributor

@dnephin dnephin commented Jan 12, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants