Merge pull request #4539 from mitchellh/ovftoolhidepassword

filter password in ovtool
hashicorp · Feb 27, 2017 · 99091a1 · 99091a1
2 parents 6628d4e + 192d550
commit 99091a1
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/post-processor/vsphere/post-processor.go b/post-processor/vsphere/post-processor.go
@@ -110,9 +110,10 @@ func (p *PostProcessor) PostProcess(ui packer.Ui, artifact packer.Artifact) (pac
 		return nil, false, fmt.Errorf("VMX, OVF or OVA file not found")
 	}
 
+	password := url.QueryEscape(p.config.Password)
 	ovftool_uri := fmt.Sprintf("vi://%s:%s@%s/%s/host/%s",
 		url.QueryEscape(p.config.Username),
-		url.QueryEscape(p.config.Password),
+		password,
 		p.config.Host,
 		p.config.Datacenter,
 		p.config.Cluster)
@@ -128,7 +129,12 @@ func (p *PostProcessor) PostProcess(ui packer.Ui, artifact packer.Artifact) (pac
 
 	ui.Message(fmt.Sprintf("Uploading %s to vSphere", source))
 
-	log.Printf("Starting ovftool with parameters: %s", strings.Join(args, " "))
+	log.Printf("Starting ovftool with parameters: %s",
+		strings.Replace(
+			strings.Join(args, " "),
+			password,
+			"<password>",
+			-1))
 	cmd := exec.Command("ovftool", args...)
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr