New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path to ssh key is resolved relative to cwd, not Vagrantfile #159

Closed
luto opened this Issue Jan 27, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@luto
Contributor

luto commented Jan 27, 2017

All the paths given in a Vagrantfile are resolved relative to the file itself, for example the ansible provisioners ansible.playbook = "site.yml". This plugin always resolves the location of the SSH key relative to the current working directory. This breaks as soon as the user tries to execute a vagrant-command in a subdirectory.

Instead the plugin should look for the SSH key files relative to the Vagrantfile.

If you agree that this should be changed, I'll be more than happy to prepare a PR for it.

@Temikus

This comment has been minimized.

Collaborator

Temikus commented Apr 25, 2017

@luto Sorry for the late response.

Yeah, I do see your point, I think it makes sense to do it, esp. considering that current directory is quite a variable when it comes to Vagrant installed as a driver.

I'll need to bump the version to next major one though as it's, in theory, a breaking change.

@luto

This comment has been minimized.

Contributor

luto commented Apr 25, 2017

Alright. I will take a closer look at where this path is resolved and prepare a PR. Thanks!

luto added a commit to luto/vagrant-google that referenced this issue May 7, 2017

Temikus added a commit to Temikus/vagrant-google that referenced this issue Oct 29, 2017

@Temikus Temikus referenced this issue Oct 29, 2017

Merged

Fix key lookup #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment