New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve google key paths relative to Vagrantfile, not cwd #167

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
3 participants
@luto
Contributor

luto commented May 7, 2017

fixes #159

@Temikus

This comment has been minimized.

Collaborator

Temikus commented May 11, 2017

LGTM! Thanks @luto

@erjohnso - can you please merge?

@erjohnso

This comment has been minimized.

Collaborator

erjohnso commented May 11, 2017

Thanks for the contribution @luto!

And thanks for the review @Temikus

@erjohnso erjohnso merged commit 3627c4f into mitchellh:master May 11, 2017

@luto luto deleted the luto:fix-159-relative-paths branch May 11, 2017

@luto

This comment has been minimized.

Contributor

luto commented May 21, 2017

Thanks for the merge!
@erjohnso is there a time frame of the next release?

@Temikus

This comment has been minimized.

Collaborator

Temikus commented Jul 4, 2017

@luto Sorry for the late response.

So it looks like releasing a new version is not entirely trivial due to some dependency issues and the fact that bundler now disallows the hack that Vagrant uses to load up plugins in development.

I'll need some time to wrangle with it and do a prerelease.

I expect to address this sometime this/next week.

@Temikus

This comment has been minimized.

Collaborator

Temikus commented Jul 24, 2017

@luto 1.0.0 released last week. Let me know if you have any questions.

@luto

This comment has been minimized.

Contributor

luto commented Jul 24, 2017

@Temikus Works great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment