Freeze dry #74

Merged
merged 6 commits into from Mar 12, 2014

Conversation

Projects
None yet
4 participants
Collaborator

elight commented Feb 25, 2014

No description provided.

Collaborator

elight commented Feb 25, 2014

Fixes #71 with help from #73 (thanks, @maxlinc).

Contributor

maxlinc commented Feb 25, 2014

@elight I updated #73 so it's got some tests and a more accurate code coverage report. Annoyingly git thinks there is a conflict between this PR and #73 but it's easily resolved (keep everything).

The test just covers the action. I haven't added any docs or an integration test covering the complete command. Still, it should be close to mergeable. Just gimme some tips on if you wanna do something different with the tests.

Collaborator

krames commented Feb 27, 2014

@maxlinc @maxlinc Since freezedry is a Rackspace specific command, should we put it in the Rackspace namespace? What do you think?

Contributor

maxlinc commented Feb 27, 2014

I'd probably make it a subcommand under the rackspace namespace, unless
you're thinking about spinning it off as a multi-provider command later.

On Thu, Feb 27, 2014 at 4:24 PM, Kyle Rames notifications@github.comwrote:

@maxlinc https://github.com/maxlinc @maxlinchttps://github.com/maxlincSince freezedry is a Rackspace specific command, should we put it in the
Rackspace namespace? What do you think?

Reply to this email directly or view it on GitHubhttps://github.com/mitchellh/vagrant-rackspace/pull/74#issuecomment-36293224
.

Collaborator

elight commented Mar 12, 2014

So now it's not "freezedry". I modified it to better adhere to the *NIX way so now you'd do something like:

vagrant rackspace images create && vagrant destroy

To create a new server, using a created image, you'd want to get the image from the images list (@maxlinc added this feature recently) and update your Vagrantfile with the image name.

vagrant rackspace images list

_Note_: I tweaked Max's impl to change rackspace images to rackspace images list because I introduced rackspace images create.

krames merged commit 211b831 into mitchellh:master Mar 12, 2014

jabclab commented Mar 13, 2014

@elight awesome! thanks for all your efforts on this 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment