Skip to content

escape quotes so that nfs export works [closes #1166] #1171

Closed
wants to merge 2 commits into from

3 participants

@sbfaulkner

fixes #1166 - this is the backport of #1170 to 1-0-stable

@clemens-tolboom clemens-tolboom commented on an outdated diff Oct 7, 2012
lib/vagrant/hosts/bsd.rb
@@ -85,6 +85,10 @@ def nfs_prune(valid_ids)
protected
+ def escape_quotes(text)
+ text.gsub(/["'\\]/) { |m| "\\#{m}" }

This should document why the backslash is escaped too. A backslash is not a quote to me.
See #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@sbfaulkner

comment added as per request

@mitchellh
Owner

While this is a pretty bad bug, I'm going to not back port this to 1.0.x because it is fairly edge case. If this becomes some sort of common issue on 1.0.x I'll look back on it but at the moment it would be a pain to back port.

@mitchellh mitchellh closed this Jul 16, 2013
@sbfaulkner

:-( unfortunate... our designers like to use spaces, quotes, etc. in their folder names... but I do get it... thanks for everything you do :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.