fix for #7610 (incorrect permissions on ~/.ssh/authorized_keys causes authentication failure after insecure keypair replacement) #7611

Merged
merged 3 commits into from Jul 20, 2016

Projects

None yet

4 participants

@Poohblah
Contributor

This fixes the issue reported in #7610. I'm not sure if any additional test cases are necessary to cover this; I can certainly write some if they are.

@Poohblah Poohblah changed the title from fix for #7610 (incorrect permissions on ~/.ssh/authorized_keys causes insecure keypair replacement failure) to fix for #7610 (incorrect permissions on ~/.ssh/authorized_keys causes authentication failure after insecure keypair replacement) Jul 19, 2016
@edestecd
edestecd commented Jul 19, 2016 edited

👍 I experienced the same issue on ubuntu directly after updating to 1.8.5 :(

Please insert this patch asap!

I'm on Virtualbox 5.0.26

@Poohblah
Contributor

Looks like unit tests are missing entirely for the remove_public_key method. I'll see if I can't get some written.

@Poohblah
Contributor

PR updated with unit tests. Also fixed a typo.

@sethvargo sethvargo added this to the 1.8.6 milestone Jul 19, 2016
@sethvargo sethvargo self-assigned this Jul 19, 2016
@pietervogelaar

Same issue here on Mac OS X after updating to Vagrant 1.8.5. I'm on VirtualBox 5.0.26.

@sethvargo sethvargo merged commit 2418cb1 into mitchellh:master Jul 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Poohblah
Contributor

Thanks @sethvargo!

@sethvargo sethvargo locked and limited conversation to collaborators Aug 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.