ModernCV: Add missing font icon commands #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelloharawild
merged commit 05a5c10
into
mitchelloharawild:master
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes #176 for me. Solution is provided by @meflynn entirely. I don't understand this part of the code so I don't know if this is the right solution.
I get the error in #176 both on Windows and Linux. I tried to update the github ubuntu runners to 18.04 or 20.04 to reproduce it in there, but stumbled upon other issues. So I don't know exactly what combination of system and software versions that causes this.