New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options: Check that all options work. #2451

Open
mhils opened this Issue Jul 19, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@mhils
Member

mhils commented Jul 19, 2017

There are currently a bunch of options that don't really work when edited while mitmproxy is running. We should go through the list, briefly (!) check which ones are working, and then work on fixing the broken ones.

  • Move @MatthewShao's excellent table in #2444 to a Google Docs/Sheets (or similar) document that allows concurrent edits and post the URL here.
  • Split options into "verified working", "to be tested", "broken/needs improvement". This should be a group effort - we just need to very briefly check if an option does anything at all. This is also a great way to learn about all the options and improve docstrings where it seems useful 😃
  • Fix the easily fixable options, discuss the not-so-easy ones. For example, cadir is a bit tricky for the reasons mentioned in #2444 (comment). One way here would be to change the directory immediately, but only create CA files on startup.
@buoy49

This comment has been minimized.

Show comment
Hide comment
@buoy49

buoy49 Jul 24, 2017

Put @MatthewShao's excellent table into a Google Sheet here.

buoy49 commented Jul 24, 2017

Put @MatthewShao's excellent table into a Google Sheet here.

@mhils

This comment has been minimized.

Show comment
Hide comment
@mhils

mhils Jul 24, 2017

Member

thanks, @bwiyy! @MatthewShao: I'm not sure how much testing you did already, can you please move the options you are sure about into the working/broken categories and let us know here one that's done? 😃

Member

mhils commented Jul 24, 2017

thanks, @bwiyy! @MatthewShao: I'm not sure how much testing you did already, can you please move the options you are sure about into the working/broken categories and let us know here one that's done? 😃

@mhils mhils added kind/feature and removed kind/enhancement labels May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment