New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift serialisation format to protobuf #2660

Closed
cortesi opened this Issue Dec 10, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@cortesi
Member

cortesi commented Dec 10, 2017

I've been working on a number of projects that use protobufs and GRPC, and I've seen the light. I propose that in the next iteration of mitmproxy, we shift our serialisation format away from our custom bson to protocol buffers. This has a number of benefits:

  • At the moment, it's tough to know exactly what's in our serialisation format, because the relevant code is spread throughout our codebase. With protobufs, we'd have a single, concise specification for what's on disk.
  • We would immediately get the ability to read and write mitmproxy's dump format from nearly all other languages "for free".
  • We would get ready to possibly use GRPC down the track, both in mitmproxy itself, and in any auxiliary services around it.

This should be done at the same time as #2196.

@cortesi cortesi added the RFC label Dec 10, 2017

@cortesi

This comment has been minimized.

Member

cortesi commented Apr 24, 2018

Superseded by #3075

@cortesi cortesi closed this Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment