Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"If you can see this, traffic is not passing through mitmproxy." #3513

Open
knlr opened this issue Apr 4, 2019 · 9 comments

Comments

@knlr
Copy link

commented Apr 4, 2019

I'm reaching the actual site and I can see the request to mitm.it in the flows window. It does not appear to be intercepted. Other requests also appear in the flows window, so my traffic is clearly passing through mitmproxy.

Steps to reproduce the problem:
  1. visit http://mitm.it from the proxy'd browser
Any other comments? What have you tried so far?

rm -rf ~/.mitmproxy didn't help

System information

Mitmproxy: 4.0.4
Python: 3.7.3
OpenSSL: OpenSSL 1.0.2r 26 Feb 2019
Platform: Darwin-18.5.0-x86_64-i386-64bit

@yan12125

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

Let me guess. Are you using mitmproxy from MacPorts?

@knlr

This comment has been minimized.

Copy link
Author

commented Apr 7, 2019

yes, I am.

@yan12125

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

Got it - sorry for the inconvenience. I disabled the plugin that handles mitm.im in macports/macports-ports@5cffb2c. The reason behind that commit is that Tornado is upgraded to 6.x in MacPorts, but the onboarding plugin is not compatible with Tornado 6.x yet. For now you'll need to install certificates on clients manually.

@knlr

This comment has been minimized.

Copy link
Author

commented Apr 7, 2019

ok thanks. I'll install it through homebrew then

@mhils

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@yan12125: Is there any way you can ship mitmproxy without disabling builtin features? This ultimately ends in support requests and confused users, which takes our time.

@mhils mhils added the upstream label Apr 15, 2019

@yan12125

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Sorry for adding troubles. I asked the maintainer of tornado in MacPorts if it's fine to revert to 5.x: https://trac.macports.org/ticket/58343#ticket.

yan12125 added a commit to yan12125/macports-ports that referenced this issue Apr 18, 2019
yan12125 added a commit to yan12125/macports-ports that referenced this issue Apr 18, 2019
@yan12125

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2019

I proposed to revert tornado in MacPorts to 5.x to allow the onboarding plugin to work again [1], but the maintainer of tornado is "not sure that's a good decision to revert tornado to old version". Is it possible to fix the onboarding plugin for tornado 6.x compatibility?

[1] macports/macports-ports#4086
[2] macports/macports-ports#4086 (comment)

yan12125 added a commit to yan12125/macports-ports that referenced this issue May 25, 2019
yan12125 added a commit to yan12125/macports-ports that referenced this issue May 25, 2019
py-mitmproxy: add a variant to enable the onboarding app via older To…
…rnado

Bump revision so that all mitmproxy users will know the current
situation.

Ref: mitmproxy/mitmproxy#3513
Closes: https://trac.macports.org/ticket/58343
yan12125 added a commit to yan12125/macports-ports that referenced this issue May 25, 2019
py-mitmproxy: add a variant to enable the onboarding app via older To…
…rnado

Bump revision so that all mitmproxy users will know the current
situation.

Ref: mitmproxy/mitmproxy#3513
Closes: https://trac.macports.org/ticket/58343
yan12125 added a commit to macports/macports-ports that referenced this issue May 29, 2019
py-mitmproxy: add a variant to enable the onboarding app via older To…
…rnado

Bump revision so that all mitmproxy users will know the current
situation.

Ref: mitmproxy/mitmproxy#3513
Closes: https://trac.macports.org/ticket/58343
@yan12125

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Finally, the patch using Tornado 5.x is merged. Tornado 5.x is not enabled by default for MacPorts users. Instead, there's a note telling users that they can enable the onboarding app with the +onboardingapp flag during installation.

@vimaldhana

This comment has been minimized.

Copy link

commented Jul 17, 2019

Hi All,

I'm a beginner to this work, trying to set up mitmproxy , installed Mitmproxy in raspberry pi when I try to run mitm.it
errors: traffic is not passing through mitmproxy
Can anyone help to resolve this issue please

mitmproxy : 5.0.0.dev
python : 3.6..8
Open SSL : OpenSSL 1.1.1 11 sep 2018
platform : Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.