New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Add tests for ducks/utils/store.js #2137

Merged
merged 2 commits into from Mar 13, 2017

Conversation

Projects
None yet
2 participants
@MatthewShao
Contributor

MatthewShao commented Mar 13, 2017

Try to add some tests for store.js. Since this is a new test for a file that we haven't covered before, if there is anything not good enough, please let me know.

@mhils

This looks great, thanks! I have some very nitpicky comments, but this already is in a very good shape. Thanks for doing this, I really appreciate testing contributions!

@mhils

mhils approved these changes Mar 13, 2017

@mhils

This comment has been minimized.

Show comment
Hide comment
@mhils

mhils Mar 13, 2017

Member

Awesome, thanks!

Member

mhils commented Mar 13, 2017

Awesome, thanks!

@mhils mhils merged commit c853091 into mitmproxy:master Mar 13, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 7d5ab70...9ce92b1
Details
codecov/project 86.41% remains the same compared to 7d5ab70
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment