New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value suggester in mitmweb options #2460

Merged
merged 15 commits into from Jul 27, 2017

Conversation

Projects
None yet
2 participants
@MatthewShao
Contributor

MatthewShao commented Jul 21, 2017

From #2450 , OptionDefault component will compare current value and the default value, if they are not the same, it will show the default value.

@MatthewShao

This comment has been minimized.

Show comment
Hide comment
@MatthewShao

MatthewShao Jul 22, 2017

Contributor

Here's a simple demo for this new feature:
peek 2017-07-22 21-18

Contributor

MatthewShao commented Jul 22, 2017

Here's a simple demo for this new feature:
peek 2017-07-22 21-18

@MatthewShao

This comment has been minimized.

Show comment
Hide comment
@MatthewShao

MatthewShao Jul 26, 2017

Contributor

I made the config file write to ~/.mitmproxy/config.yaml, which is identical to the path in the console. So when we update the options in mitmweb and then switch to mitmproxy, the dumped options can be loaded automatically.

Contributor

MatthewShao commented Jul 26, 2017

I made the config file write to ~/.mitmproxy/config.yaml, which is identical to the path in the console. So when we update the options in mitmweb and then switch to mitmproxy, the dumped options can be loaded automatically.

@mhils

This looks great! 👍

Show outdated Hide outdated mitmproxy/tools/web/app.py
Show outdated Hide outdated mitmproxy/tools/web/app.py
Show outdated Hide outdated mitmproxy/tools/web/master.py
Show outdated Hide outdated web/src/js/__tests__/ducks/optionsSpec.js
@mhils

mhils approved these changes Jul 27, 2017

👍 🍰

@mhils mhils merged commit 357928b into mitmproxy:master Jul 27, 2017

2 of 4 checks passed

codecov/patch 87.5% of diff hit (target 87.92%)
Details
codecov/project 87.92% (-0.01%) compared to d409a6c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment