New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifting to Protobuf Serialization - Cleaned #3245

Merged
merged 18 commits into from Jul 21, 2018

Conversation

Projects
None yet
3 participants
@madt1m
Copy link
Member

madt1m commented Jul 12, 2018

This should be clean and ready to be merged. I have checked out tmp.sqlite from both repo and history (.sqlite files are now ignored by git) and refactored DbHandler class into the righteous DBHandler.
Let me know if anything else has to be addressed.

@madt1m madt1m force-pushed the madt1m:protobuf-serialization-clean branch from 22aadc9 to d5da746 Jul 17, 2018

@madt1m

This comment has been minimized.

Copy link
Member Author

madt1m commented Jul 19, 2018

So, can this be merged? I'll work on these files, and use this interface, in the next few PRs, so I need it to proceed!

@mhils

mhils approved these changes Jul 20, 2018

Copy link
Member

mhils left a comment

This looks good to me - @cortesi?

@@ -0,0 +1,93 @@
syntax='proto2';

This comment has been minimized.

@mhils

mhils Jul 20, 2018

Member

Is there a particular reason why we went with proto2 and not proto3?

(both is fine with me, just curious)

This comment has been minimized.

@madt1m

madt1m Jul 20, 2018

Author Member

Nothing in particular. I found more documentation and examples for proto2 syntax, and I didn't want to preclude required fields in messages.

@cortesi cortesi merged commit ec092fd into mitmproxy:master Jul 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment