Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Session - Storage Layer #3277
Here we are, this is a crucial step in the development of the Session addon. Considering this, I would appreciate so much any critic, review and comment which can ensure this piece of work to meet the standard quality of the codebase.
I've sketched down how the logic behind the storage layer behaves.
Main Data Structures:
Once storage layer is ok, it will be time to implement an API which mirrors View one, to finally test for interoperability and complete the layer. This will require some work out of the addon - as debated some weeks ago - to extend command typing, handle blinker Signals subscription via API and implement some way to "plug" storage modules, to replace View with Session during testing phase (and hopefully, afterwards).
During this piece of work, I wrote a fair amount of new code, and made lots of design choices in the process. Some of them could be good, some bad, so:
word to the CI!
cortesi left a comment •
This is an excellent patch, and will be a solid basis for our next steps. Let's do a round of tweaks before we merge. I'll summarise my review as follows: