Skip to content

/pdoc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building results in version 0.0.0 #161

Closed
ecederstrand opened this issue Aug 15, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ecederstrand
@ecederstrand
Copy link
Contributor

commented Aug 15, 2018 •
edited

I ran python3 setup.py sdist on the latest source and got a resulting dist/pdoc-0.0.0.tar.gz file.

This is because setup.py looks for __version__ in pdoc/__init__ but it's actually located in pdoc/doc.py.

setup.py should look in pdoc/doc.py instead, and pdoc/__init__.py should contain a from .doc import __version__ so import pdoc; pdoc.__version__ works as expected.

ecederstrand added a commit to ecederstrand/pdoc that referenced this issue Aug 15, 2018

@ecederstrand
make import pdoc; pdoc.__version__ work. Refs mitmproxy#161
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
41f1405
@ecederstrand

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 27, 2018

Hi @cortesi

Could you kindly have a look at this and my other issues and pull requests? I'll happily work to get them in a committable state if you have any comments.

ecederstrand pushed a commit to ecederstrand/pdoc that referenced this issue Sep 7, 2018

EKC (Erik Cederstrand)
Revert "Read __version__ from the correct file. Fixes mitmproxy#161" 
This reverts commit 9649963.
ca6d430

@mhils mhils closed this in 9649963 Sep 7, 2018

mhils added a commit that referenced this issue Sep 7, 2018

@mhils
Merge pull request #162 from ecederstrand/patch-1 
Read __version__ from the correct file. Fixes #161
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2988af6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.