Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upWas support for Python < 3.6 intentionally dropped? #164
Comments
This comment has been minimized.
This comment has been minimized.
|
I have created a PR to restore Python 3.5 support. The changes are minimal. |
This comment has been minimized.
This comment has been minimized.
mitsuhiko
commented
Sep 7, 2018
|
Did that also drop 2.7 support or was that dropped earlier? Because on Python 3 all methods are misreported as static methods which is why I'm currently forced to use Python 2.7 and I noticed master does not work with it. |
This comment has been minimized.
This comment has been minimized.
|
2.7 was dropped earlier, see #148. 3.5 is definitely something we want to support for now, I'll take a look at @ecederstrand's excellent PR in a minute. |
This comment has been minimized.
This comment has been minimized.
mitsuhiko
commented
Sep 7, 2018
mhils
closed this
in
#165
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ecederstrand commentedAug 20, 2018
•
edited
b22f988#diff-6e25b76e2e8ac358872ad54a4fd44420 introduced f-strings which were introduced in Python 3.6. But
setup.pyjust advertises thatpdocsupports Python 3.*:pdoc/setup.py
Line 34 in d27d983
Dropping Python 3.5 already is maybe a bit harsh, but at least setup.py should be updated to note the change.