Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was support for Python < 3.6 intentionally dropped? #164

Closed
ecederstrand opened this issue Aug 20, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@ecederstrand
Copy link
Contributor

commented Aug 20, 2018

b22f988#diff-6e25b76e2e8ac358872ad54a4fd44420 introduced f-strings which were introduced in Python 3.6. But setup.py just advertises that pdoc supports Python 3.*:

pdoc/setup.py

Line 34 in d27d983

"Programming Language :: Python :: 3",

Dropping Python 3.5 already is maybe a bit harsh, but at least setup.py should be updated to note the change.

@ecederstrand

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2018

I have created a PR to restore Python 3.5 support. The changes are minimal.

@mitsuhiko

This comment has been minimized.

Copy link

commented Sep 7, 2018

Did that also drop 2.7 support or was that dropped earlier? Because on Python 3 all methods are misreported as static methods which is why I'm currently forced to use Python 2.7 and I noticed master does not work with it.

@mhils

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

2.7 was dropped earlier, see #148.

3.5 is definitely something we want to support for now, I'll take a look at @ecederstrand's excellent PR in a minute.

@mitsuhiko

This comment has been minimized.

Copy link

commented Sep 7, 2018

@mhils then the extractor needs to be fixed. It reports all methods as static methods (#48)

@mhils mhils closed this in #165 Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.