Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL License violation #1008

Closed
graingert opened this issue Sep 12, 2016 · 9 comments
Closed

GPL License violation #1008

graingert opened this issue Sep 12, 2016 · 9 comments

Comments

@graingert
Copy link

graingert commented Sep 12, 2016

Currently you use wowjs it's under the GPL. I maintain a fork from when the library was MIT (wow.js) see https://wowjs.uk

This version is completely UMD compatible and doesn't need any hacks.

You could also use AOS instead

@pdpinch
Copy link
Member

pdpinch commented Sep 12, 2016

Thanks for the tip, but I don't think this repo uses wow.js. Were you looking at the current website at http://micromasters.mit.edu/ ? It looks like it does use wow.js.

@graingert
Copy link
Author

@pdpinch
Copy link
Member

pdpinch commented Sep 12, 2016

Ah, github search... how useless can you be?

@pdpinch
Copy link
Member

pdpinch commented Sep 12, 2016

No, not at all. My comment was about the uselessness of github's search tool.

Again, thanks for the tip. We'll take a look into switching the library.

@graingert
Copy link
Author

graingert commented Sep 12, 2016

Ah, I misunderstood, deleted.

@noisecapella
Copy link
Contributor

@pdpinch AFAIK wow.js just came with the home page and program page code from the designer. I'm not sure we actually use it at all, and we'll be getting rid of it soon in any case with the new redesign

@graingert
Copy link
Author

graingert commented Sep 12, 2016

probably worth just nixing the animations completely from the homepage until the redesign, rather than replacing it?

@noisecapella
Copy link
Contributor

I think so. Thanks for bringing this to our attention!

@graingert
Copy link
Author

@noisecapella you guys probably want to use something like https://github.com/davglass/license-checker to check for MIT incompatible licenses

graingert added a commit to graingert/micromasters that referenced this issue Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants