From 7bbd904dec99c0f278dc1e9aff9ab4858ec83131 Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 09:56:12 -0400 Subject: [PATCH 01/11] change topic(s) to 'topic' --- .../mit-open/src/pages/HomePage/BrowseTopicsSection.tsx | 2 +- frontends/mit-open/src/pages/HomePage/HeroSearch.tsx | 2 +- frontends/mit-open/src/pages/HomePage/HomePage.test.tsx | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontends/mit-open/src/pages/HomePage/BrowseTopicsSection.tsx b/frontends/mit-open/src/pages/HomePage/BrowseTopicsSection.tsx index 34d3020614..41dddefc55 100644 --- a/frontends/mit-open/src/pages/HomePage/BrowseTopicsSection.tsx +++ b/frontends/mit-open/src/pages/HomePage/BrowseTopicsSection.tsx @@ -99,7 +99,7 @@ const BrowseTopicsSection: React.FC = () => { return (
- Browse by Topics + Browse by Topic {topics?.results.map(({ id, name, channel_url: channelUrl }) => { return ( diff --git a/frontends/mit-open/src/pages/HomePage/HeroSearch.tsx b/frontends/mit-open/src/pages/HomePage/HeroSearch.tsx index a7ff529819..1ed4ade3cf 100644 --- a/frontends/mit-open/src/pages/HomePage/HeroSearch.tsx +++ b/frontends/mit-open/src/pages/HomePage/HeroSearch.tsx @@ -213,7 +213,7 @@ const HeroSearch: React.FC = () => { grow variant="outlined" size="medium" - label="Browse by Topics" + label="Browse by Topic" href="/topics/" /> { { label: "Upcoming", href: "/search?sortby=upcoming" }, { label: "Free", href: "/search?free=true" }, { label: "With Certificate", href: "/search?certification=true" }, - { label: "Browse by Topics", href: "/topics/" }, + { label: "Browse by Topic", href: "/topics/" }, { label: "Explore All", href: "/search/" }, ] expected.forEach(({ label, href }) => { @@ -173,7 +173,7 @@ describe("Home Page Carousel", () => { }) }) -describe("Home Page Browse by Topics", () => { +describe("Home Page Browse by Topic", () => { test("Displays topics links", async () => { setupAPIs() const response = learningResources.topics({ count: 3 }) @@ -184,7 +184,7 @@ describe("Home Page Browse by Topics", () => { await waitFor(() => { const section = screen .getByRole("heading", { - name: "Browse by Topics", + name: "Browse by Topic", })! .closest("section")! From d3e5288cf17cb2c92cddb286bd93b2de44bec066 Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 09:57:36 -0400 Subject: [PATCH 02/11] fix copy for 'professional and executive learning' --- frontends/mit-open/src/pages/HomePage/HomePage.test.tsx | 4 ++-- frontends/mit-open/src/pages/HomePage/carousels.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontends/mit-open/src/pages/HomePage/HomePage.test.tsx b/frontends/mit-open/src/pages/HomePage/HomePage.test.tsx index 9ddab90ee5..20d77c741c 100644 --- a/frontends/mit-open/src/pages/HomePage/HomePage.test.tsx +++ b/frontends/mit-open/src/pages/HomePage/HomePage.test.tsx @@ -131,7 +131,7 @@ describe("Home Page Carousel", () => { }, }, { - tab: "Professional and Executive Learning", + tab: "Professional & Executive Learning", params: { resource_type: ["course"], limit: 12, professional: true }, }, ])("Featured Courses Carousel Tabs", async ({ tab, params }) => { @@ -165,7 +165,7 @@ describe("Home Page Carousel", () => { within(featured).getByRole("tab", { name: "Free" }) within(featured).getByRole("tab", { name: "With Certificate" }) within(featured).getByRole("tab", { - name: "Professional and Executive Learning", + name: "Professional & Executive Learning", }) within(media).getByRole("tab", { name: "All" }) within(media).getByRole("tab", { name: "Videos" }) diff --git a/frontends/mit-open/src/pages/HomePage/carousels.ts b/frontends/mit-open/src/pages/HomePage/carousels.ts index ec12cf29db..b77f549cb1 100644 --- a/frontends/mit-open/src/pages/HomePage/carousels.ts +++ b/frontends/mit-open/src/pages/HomePage/carousels.ts @@ -35,7 +35,7 @@ const FEATURED_RESOURCES_CAROUSEL: ResourceCarouselProps["config"] = [ }, }, { - label: "Professional and Executive Learning", + label: "Professional & Executive Learning", cardProps: { size: "medium" }, data: { type: "lr_featured", From 3eed4f0ae92653a7ab88fca1d5ed87af6f4d7829 Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 09:58:37 -0400 Subject: [PATCH 03/11] copy edit on testimonial section --- frontends/mit-open/src/pages/HomePage/TestimonialsSection.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontends/mit-open/src/pages/HomePage/TestimonialsSection.tsx b/frontends/mit-open/src/pages/HomePage/TestimonialsSection.tsx index c76eeb3c58..068152db7f 100644 --- a/frontends/mit-open/src/pages/HomePage/TestimonialsSection.tsx +++ b/frontends/mit-open/src/pages/HomePage/TestimonialsSection.tsx @@ -258,7 +258,7 @@ const TestimonialsSection: React.FC = () => { From our Community - Here's what other subscribers had to say about MIT Open + Transforming education through the eyes of our learners From 69a0756a2a70699e809834c19a0e593d3d9c3589 Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 10:04:06 -0400 Subject: [PATCH 04/11] copy edits to field pages --- frontends/mit-open/src/pages/FieldPage/FieldPageSkeleton.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontends/mit-open/src/pages/FieldPage/FieldPageSkeleton.tsx b/frontends/mit-open/src/pages/FieldPage/FieldPageSkeleton.tsx index a113d85d33..d11a53e247 100644 --- a/frontends/mit-open/src/pages/FieldPage/FieldPageSkeleton.tsx +++ b/frontends/mit-open/src/pages/FieldPage/FieldPageSkeleton.tsx @@ -55,11 +55,11 @@ interface FieldSkeletonProps { const NAV_PATH: { [key: string]: { href: string; label: string } } = { topic: { href: TOPICS, - label: "Topics", + label: "Browse by Topic", }, department: { href: DEPARTMENTS, - label: "Departments", + label: "Browse by Academic Department", }, unit: { href: UNITS, From 077cc7e80a011328d1c6ba583bdc969d97a48076 Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 10:06:40 -0400 Subject: [PATCH 05/11] copy edit on topic page --- .../mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx b/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx index cf3644a0bd..aa8766ed95 100644 --- a/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx +++ b/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx @@ -287,7 +287,7 @@ const ToopicsListingPage: React.FC = () => { current="Topics" /> } - title="Topics" + title="Browse by Topic" description="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam." backgroundUrl={TOPICS_BANNER_IMAGE} /> From 04970845a4272e6ed7251a1f694c06e5db601cf6 Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 10:07:42 -0400 Subject: [PATCH 06/11] fixing test --- .../src/pages/TopicListingPage/TopicsListingPage.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.test.tsx b/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.test.tsx index 0828c8efc2..fa3badbfb4 100644 --- a/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.test.tsx +++ b/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.test.tsx @@ -92,7 +92,7 @@ describe("DepartmentListingPage", () => { await waitFor(() => { expect(document.title).toBe("Topics | MIT Open") }) - screen.getByRole("heading", { name: "Topics" }) + screen.getByRole("heading", { name: "Browse by Topic" }) }) it("Lists subtopics grouped by topic", async () => { From c66b6ff527bc97a447ff5074467ea53ef7a0e8c7 Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 10:08:40 -0400 Subject: [PATCH 07/11] removing placeholder sub heading on topic field page --- .../mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx b/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx index aa8766ed95..48d4f69a8a 100644 --- a/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx +++ b/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx @@ -288,7 +288,6 @@ const ToopicsListingPage: React.FC = () => { /> } title="Browse by Topic" - description="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam." backgroundUrl={TOPICS_BANNER_IMAGE} /> From ae775a844d81b2dbfbe1b6ca36f3824b8794ef14 Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 10:10:20 -0400 Subject: [PATCH 08/11] fixing placeholder text in search bar --- frontends/mit-open/src/pages/SearchPage/SearchPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontends/mit-open/src/pages/SearchPage/SearchPage.tsx b/frontends/mit-open/src/pages/SearchPage/SearchPage.tsx index cbc79c0f33..61d88de735 100644 --- a/frontends/mit-open/src/pages/SearchPage/SearchPage.tsx +++ b/frontends/mit-open/src/pages/SearchPage/SearchPage.tsx @@ -189,7 +189,7 @@ const SearchPage: React.FC = () => { onClear={() => { setCurrentTextAndQuery("") }} - placeholder="Search for resources" + placeholder="What do you want to learn?" /> From 18c72563f4628841688f633e9feba099584a3caa Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 10:23:57 -0400 Subject: [PATCH 09/11] changing copy on departments page --- .../pages/DepartmentListingPage/DepartmentListingPage.test.tsx | 2 +- .../src/pages/DepartmentListingPage/DepartmentListingPage.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frontends/mit-open/src/pages/DepartmentListingPage/DepartmentListingPage.test.tsx b/frontends/mit-open/src/pages/DepartmentListingPage/DepartmentListingPage.test.tsx index 7d67007d27..512cf93d58 100644 --- a/frontends/mit-open/src/pages/DepartmentListingPage/DepartmentListingPage.test.tsx +++ b/frontends/mit-open/src/pages/DepartmentListingPage/DepartmentListingPage.test.tsx @@ -88,7 +88,7 @@ describe("DepartmentListingPage", () => { await waitFor(() => { expect(document.title).toBe("Departments | MIT Open") }) - screen.getByRole("heading", { name: "Departments" }) + screen.getByRole("heading", { name: "Browse by Academic Department" }) }) it("Lists schools and departments", async () => { diff --git a/frontends/mit-open/src/pages/DepartmentListingPage/DepartmentListingPage.tsx b/frontends/mit-open/src/pages/DepartmentListingPage/DepartmentListingPage.tsx index 90a4beed94..c22ccd71a5 100644 --- a/frontends/mit-open/src/pages/DepartmentListingPage/DepartmentListingPage.tsx +++ b/frontends/mit-open/src/pages/DepartmentListingPage/DepartmentListingPage.tsx @@ -218,7 +218,7 @@ const DepartmentListingPage: React.FC = () => { Date: Thu, 20 Jun 2024 10:36:10 -0400 Subject: [PATCH 10/11] lint fix --- .../mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx b/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx index 48d4f69a8a..9126a3e3bd 100644 --- a/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx +++ b/frontends/mit-open/src/pages/TopicListingPage/TopicsListingPage.tsx @@ -288,6 +288,7 @@ const ToopicsListingPage: React.FC = () => { /> } title="Browse by Topic" + description="" backgroundUrl={TOPICS_BANNER_IMAGE} /> From 1d92317d8140bb019db8f29f7a0e6e4e6c730acd Mon Sep 17 00:00:00 2001 From: shankar ambady Date: Thu, 20 Jun 2024 11:07:21 -0400 Subject: [PATCH 11/11] updating login button --- frontends/mit-open/src/page-components/Header/UserMenu.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontends/mit-open/src/page-components/Header/UserMenu.tsx b/frontends/mit-open/src/page-components/Header/UserMenu.tsx index f06c30bfa8..e422394217 100644 --- a/frontends/mit-open/src/page-components/Header/UserMenu.tsx +++ b/frontends/mit-open/src/page-components/Header/UserMenu.tsx @@ -157,7 +157,7 @@ const UserMenu: React.FC = ({ variant }) => { reloadDocument={true} href={loginUrl} > - Sign Up / Log In + Log In ) : (