Remap topic icons according to what's in the topics listing #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This really requires a refactor to use the topics that are specified in the API - this is a quick fix so the topics code can be released sooner.
jkachel
added
Needs Review
jonkafton
approved these changes
Jul 26, 2024
This was referenced Jul 26, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
n/a
Description (What does it do?)
The topic icons are hard-coded in the
RootTopicIconcomponent. Those topics have changed, though - in #1275 we've changed the name of some root topics and added others, so this fixes the map inRootTopicIconso that it matches the new setup.How can this be tested?
Load the homepage. You should see icons in the Browse by Topic section and they should match the root icons listed in the topics.yaml file (or in the database).