From 500010180313bd086dcc06ddc9eb908af6d2990a Mon Sep 17 00:00:00 2001 From: Anastasia Beglova Date: Wed, 11 Sep 2024 16:09:38 -0400 Subject: [PATCH] Fix refreshes and deterministic sort order --- .../mit-learn/src/services/react-query/react-query.ts | 3 ++- learning_resources_search/api.py | 2 +- learning_resources_search/api_test.py | 10 +++++++++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/frontends/mit-learn/src/services/react-query/react-query.ts b/frontends/mit-learn/src/services/react-query/react-query.ts index 2f9f0e1e22..817b4a1cc2 100644 --- a/frontends/mit-learn/src/services/react-query/react-query.ts +++ b/frontends/mit-learn/src/services/react-query/react-query.ts @@ -16,7 +16,8 @@ const createQueryClient = (): QueryClient => { return new QueryClient({ defaultOptions: { queries: { - staleTime: 30 * 1000, + refetchOnWindowFocus: false, + staleTime: Infinity, queryFn: async ({ queryKey }) => { const url = queryKey[0] if (typeof url !== "string" || queryKey.length !== 1) { diff --git a/learning_resources_search/api.py b/learning_resources_search/api.py index 8826a6c3dd..eb4582a581 100644 --- a/learning_resources_search/api.py +++ b/learning_resources_search/api.py @@ -39,7 +39,7 @@ LEARN_SUGGEST_FIELDS = ["title.trigram", "description.trigram"] COURSENUM_SORT_FIELD = "course.course_numbers.sort_coursenum" -DEFAULT_SORT = ["featured_rank", "is_learning_material"] +DEFAULT_SORT = ["featured_rank", "is_learning_material", "-created_on"] def gen_content_file_id(content_file_id): diff --git a/learning_resources_search/api_test.py b/learning_resources_search/api_test.py index 9450f73105..71282429f5 100644 --- a/learning_resources_search/api_test.py +++ b/learning_resources_search/api_test.py @@ -2636,7 +2636,15 @@ def test_document_percolation(opensearch, mocker): [ ("-views", None, [{"views": {"order": "desc"}}]), ("-views", "text", [{"views": {"order": "desc"}}]), - (None, None, ["featured_rank", "is_learning_material"]), + ( + None, + None, + [ + "featured_rank", + "is_learning_material", + {"created_on": {"order": "desc"}}, + ], + ), (None, "text", None), ], )