From 74d9f9effd8a1623c15364f8c8f40662e22bae3e Mon Sep 17 00:00:00 2001 From: James Kachel Date: Fri, 18 Oct 2024 13:29:51 -0500 Subject: [PATCH 1/2] Capture the search_update event after making the adjustments to search terms (#1709) --- .../src/page-components/SearchDisplay/SearchDisplay.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frontends/mit-learn/src/page-components/SearchDisplay/SearchDisplay.tsx b/frontends/mit-learn/src/page-components/SearchDisplay/SearchDisplay.tsx index 0179f2830c..d82812538a 100644 --- a/frontends/mit-learn/src/page-components/SearchDisplay/SearchDisplay.tsx +++ b/frontends/mit-learn/src/page-components/SearchDisplay/SearchDisplay.tsx @@ -610,20 +610,20 @@ const SearchDisplay: React.FC = ({ } const setParamValue = (value: string, prev: string | string[]) => { - captureSearchEvent() actuallySetParamValue(value, prev) + captureSearchEvent() } const clearAllFacets = () => { - captureSearchEvent() actuallyClearAllFacets() + captureSearchEvent() } const setSearchParams = ( value: URLSearchParams | ((prev: URLSearchParams) => URLSearchParams), ) => { - captureSearchEvent() actuallySetSearchParams(value) + captureSearchEvent() } const toggleParamValue = ( @@ -631,8 +631,8 @@ const SearchDisplay: React.FC = ({ rawValue: string, checked: boolean, ) => { - captureSearchEvent() actuallyToggleParamValue(name, rawValue, checked) + captureSearchEvent() } const sortDropdown = ( From 5d1b62843e821fe3c910bb84d777672fc94ca044 Mon Sep 17 00:00:00 2001 From: Chris Chudzicki Date: Mon, 21 Oct 2024 09:11:50 -0400 Subject: [PATCH 2/2] fix textarea placeholder color (#1712) --- frontends/ol-components/src/components/Input/Input.tsx | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/frontends/ol-components/src/components/Input/Input.tsx b/frontends/ol-components/src/components/Input/Input.tsx index 9b2751b7ed..21014c63ab 100644 --- a/frontends/ol-components/src/components/Input/Input.tsx +++ b/frontends/ol-components/src/components/Input/Input.tsx @@ -116,17 +116,16 @@ const baseInputStyles = (theme: Theme) => ({ borderColor: "transparent", outline: "2px solid currentcolor", outlineOffset: "-2px", - color: theme.custom.colors.darkGray2, }, "&.Mui-error": { borderColor: theme.custom.colors.red, outlineColor: theme.custom.colors.red, }, - "& input::placeholder": { + "& input::placeholder, textarea::placeholder": { color: theme.custom.colors.silverGrayDark, opacity: 1, // some browsers apply opacity to placeholder text }, - "& input:placeholder-shown": { + "& input:placeholder-shown, textarea:placeholder-shown": { textOverflow: "ellipsis", }, "& textarea": { @@ -154,7 +153,7 @@ const baseInputStyles = (theme: Theme) => ({ type CustomInputProps = { responsive?: true } const noForward = Object.keys({ responsive: true, -} satisfies { [key in keyof CustomInputProps]: boolean }) +} satisfies { [_key in keyof CustomInputProps]: boolean }) const Input = styled(InputBase, { shouldForwardProp: (prop) => !noForward.includes(prop),