-
Notifications
You must be signed in to change notification settings - Fork 44
REVIEW: Initial release pull requests to capture all comments to PyLTI 0.1.3 #3
Conversation
Adding tests for LTI.name()
|
Changes Unknown when pulling f26a7f2 on develop into * on master*. |
|
Changes Unknown when pulling ea64365 on develop into * on master*. |
|
@pdpinch requirements.txt that I have now include all things needed to run tests. tests_require=["pytest-cov>=1.8.0", "pytest-pep8>=1.0.6", It makes sense to me to add all test requirements to the requirements.txt as it allows a contributor to run tests as well. Installing library requires only oauth, oauth2 and httplib2 (which is required by oauth2, but we noticed that occasionally does not install so it's added to our requires). |
REVIEW: Initial release pull requests to capture all comments to PyLTI 0.1.3
Initial release pull requests to capture all comments to PyLTI 0.1.3.
We'll close this one on Thursday 10/30. This is opportunity to comment on the initial code release.