Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

Conversation

@iceraj
Copy link
Contributor

@iceraj iceraj commented Oct 28, 2014

Initial release pull requests to capture all comments to PyLTI 0.1.3.

We'll close this one on Thursday 10/30. This is opportunity to comment on the initial code release.

@iceraj iceraj changed the title Initial release pull requests to capture all comments to PyLTI 0.1.1 REVIEW: Initial release pull requests to capture all comments to PyLTI 0.1.1 Oct 28, 2014
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f26a7f2 on develop into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ea64365 on develop into * on master*.

@iceraj
Copy link
Contributor Author

iceraj commented Oct 31, 2014

@pdpinch requirements.txt that I have now include all things needed to run tests.

tests_require=["pytest-cov>=1.8.0", "pytest-pep8>=1.0.6",
"pytest-flakes>=0.2", "pytest>=2.6.3",
"httpretty>=0.8.3", "flask>=0.10.1",
"oauthlib>=0.6.3", "semantic_version>=2.3.1"],
install_requires=["oauth>=1.0.1", "oauth2>=1.5.211",
"httplib2>=0.9" ],

It makes sense to me to add all test requirements to the requirements.txt as it allows a contributor to run tests as well. Installing library requires only oauth, oauth2 and httplib2 (which is required by oauth2, but we noticed that occasionally does not install so it's added to our requires).

@iceraj iceraj changed the title REVIEW: Initial release pull requests to capture all comments to PyLTI 0.1.1 REVIEW: Initial release pull requests to capture all comments to PyLTI 0.1.3 Oct 31, 2014
iceraj added a commit that referenced this pull request Oct 31, 2014
REVIEW: Initial release pull requests to capture all comments to PyLTI 0.1.3
@iceraj iceraj merged commit 8408963 into master Oct 31, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants