Skip to content

Commit 2c7af9f

Browse files
committed
service: PushFileService never recorded a file as sent.
Ansible modules were being resent continuously - but only the main script module, and any custom modutils if any were present. Wire footprint drops by ~1/3rd for a 500 task run of 'shell: hostname': -rw-r--r-- 1 root root 584K Jan 31 22:06 500mito-before2 -rw-r--r-- 1 root root 434K Jan 31 22:04 500mito-filesbugonly
1 parent 7cdbf36 commit 2c7af9f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

mitogen/service.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -634,14 +634,15 @@ def _forward(self, context, path):
634634
path=path,
635635
context=context
636636
).close()
637-
else:
637+
elif path not in sent:
638638
child.call_service_async(
639639
service_name=self.name(),
640640
method_name='store_and_forward',
641641
path=path,
642642
data=self._cache[path],
643643
context=context
644644
).close()
645+
sent.add(path)
645646

646647
@expose(policy=AllowParents())
647648
@arg_spec({

0 commit comments

Comments
 (0)