mitogen.parent.cfmakeraw() contains repeated flags

[moreati]

E.g. BRKINT is specified twice

mitogen/mitogen/parent.py

Lines 249 to 256 in b8b1558

	iflag &= ~flags('IMAXBEL IXOFF INPCK BRKINT PARMRK '
	'ISTRIP INLCR ICRNL IXON IGNPAR')
	iflag &= ~flags('IGNBRK BRKINT PARMRK')
	oflag &= ~flags('OPOST')
	lflag &= ~flags('ECHO ECHOE ECHOK ECHONL ICANON ISIG '
	'IEXTEN NOFLSH TOSTOP PENDIN')
	cflag &= ~flags('CSIZE PARENB')
	cflag |= flags('CS8 CREAD')

Discovered during review of #1089

[moreati]

>>> 'IMAXBEL IXOFF INPCK BRKINT PARMRK ' 'ISTRIP INLCR ICRNL IXON IGNPAR' ' ' 'IGNBRK BRKINT PARMRK'
'IMAXBEL IXOFF INPCK BRKINT PARMRK ISTRIP INLCR ICRNL IXON IGNPAR IGNBRK BRKINT PARMRK'
>>> sorted(_.split())
['BRKINT', 'BRKINT', 'ICRNL', 'IGNBRK', 'IGNPAR', 'IMAXBEL', 'INLCR', 'INPCK', 'ISTRIP', 'IXOFF', 'IXON', 'PARMRK', 'PARMRK']
>>> 'IMAXBEL IXOFF INPCK BRKINT PARMRK ' 'ISTRIP INLCR ICRNL IXON IGNPAR' ' ' 'IGNBRK BRKINT PARMRK'
'IMAXBEL IXOFF INPCK BRKINT PARMRK ISTRIP INLCR ICRNL IXON IGNPAR IGNBRK BRKINT PARMRK'
>>> sorted(_.split())
['BRKINT', 'BRKINT', 'ICRNL', 'IGNBRK', 'IGNPAR', 'IMAXBEL', 'INLCR', 'INPCK', 'ISTRIP', 'IXOFF', 'IXON', 'PARMRK', 'PARMRK']
>>> sorted(set(_))
['BRKINT', 'ICRNL', 'IGNBRK', 'IGNPAR', 'IMAXBEL', 'INLCR', 'INPCK', 'ISTRIP', 'IXOFF', 'IXON', 'PARMRK']
>>> ' '.join(_)
'BRKINT ICRNL IGNBRK IGNPAR IMAXBEL INLCR INPCK ISTRIP IXOFF IXON PARMRK'

[moreati]

https://github.com/mitogen-hq/mitogen/wiki/cfmakeraw-notes

[moreati]

Mitogen attempts to (un)set a few non-POSIX flags

• iflag
  • IMAXBEL=0 - Ring bell when input queue is full. Not implemented on Linux, always behaves as on.
• oflag
  • CREAD=1 - Enable receiver
• lflag
  • PENDIN=0 - Reprint characters in input queue when next source character is read. Not supported on Linux, marked XXX in https://man.freebsd.org/cgi/man.cgi?query=termios&sektion=4&apropos=0&manpath=FreeBSD+14.2-RELEASE+and+Ports#Local+Modes

[moreati]

Mitogen does not modify a few flags that others do modify

• iflag
  • IGNCR - Ignore Carriage Return. Removed in 56943d3
• cc
  • VMIN & VTIME - determine blocking beahviour of read() calls

Mitogen may silently (un)set any flag that has no corresponding entry in the Python module termios, by way of getattr(..., termios, 0).

[moreati]

Previous discussion #71