Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 related issue #349

Closed
svinota opened this issue Aug 23, 2018 · 3 comments
Closed

Python3 related issue #349

svinota opened this issue Aug 23, 2018 · 3 comments

Comments

@svinota
Copy link

@svinota svinota commented Aug 23, 2018

Trying to run the code under python3 I get an error — see the log attached: error.log

The issue gets reproduced on the latest master as well.

The Python version is 3.6.5, the host system is Fedora, the target is Debian, Python versions are the same.

Under Python 2 there are no issues.

@dw
Copy link
Member

@dw dw commented Aug 23, 2018

Python 3 recently introduced this new "importer spec" business and seems it doesn't handle aliases well, or I'm not doing things right. Thanks for reporting this -- both fixes should be pretty straightforward

@dw
Copy link
Member

@dw dw commented Jan 20, 2019

Hi,

Looking at this again, it seems the main problem was the format string -- actually the case of missing get_filename() is already handled by the code. Closing this off :)

Thanks again for reporting this!

@dw dw closed this Jan 20, 2019
@dw
Copy link
Member

@dw dw commented Jan 20, 2019

btw, there is another bug open for that stdlib roundtrip problem -- the client should know not to ask for it whatsoever. So far it seems to be a minor nit rather than a perf showstopper, thankfully

dw added a commit that referenced this issue Jan 20, 2019
dw added a commit that referenced this issue Jan 20, 2019
* origin/dmw:
  issue #310: fix test failures, teach old import method new tricks
  master: handle crazy non-modules in sys.modules again; closes #310.
  issue #349: update Changelog.
  docs: add unused import to Changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants