Fix AnsibleUnsafeText when copying files larger than SMALL_FILE_LIMIT#1110
Merged
Conversation
Member
|
refs #1046 |
Member
|
related to #1087. @jrosser thank for these PRs.
|
Author
|
@moreati Yes please do rebase / adjust any of my PR as needed to get them suitable to merge. Adding https://github.com/jrosser to the contributors list would be nice - thankyou. |
Author
Member
In progress. Notes to self
|
Member
|
Like #1087 this only occurs in a - hosts: localhost
gather_facts: false
vars:
chonkers:
- {src: ~/tmp/150kiB_seed_1234_v1, dest: /tmp/150kiB_seed_1234_v1}
- {src: ~/tmp/150kiB_seed_1234_v1.copy, dest: /tmp/150kiB_seed_1234_v1}
- {src: ~/tmp/150kiB_seed_1234_v1, dest: /tmp/150kiB_seed_1234_v1.data}
- {src: ~/tmp/150kiB_seed_1234_v1.copy, dest: /tmp/150kiB_seed_1234_v1.data}
tasks:
- copy:
src: "{{ item.src }}"
dest: "{{ item.dest }}"
mode: u=rw,go=r
with_items: "{{ chonkers }}"
- name: Cleanup 1
file:
path: "{{ item.dest }}"
state: absent
with_items: "{{ chonkers }}" |
This is in anticipation of mitogen-hq#1110, which only exhibits inside a with_items: loop. For this refactor `loop:` is used, to confirm the refactored tests are still correct. A subsequent commit will change them to with_items. The content of the files and their SHA1 checksums are unchanged.
Small files are carried in-band in the communication between controller and remote, with larger files being copied by falling back to a more traditional ansible put_file mechanism. This large file code path was missed in b822f20.
Member
|
Confirm that the loop driven version of tests/ansible/integration/copy.yml in moreati@ce1acce fails if all |
The bug was fixed in a previous commit by Jonathan Rosser. This adds testing. The bug is only triggered when the copy module is used inside a `with_items:` loop and the destination filename has an extension. A `loop:` loop is not sufficient. refs mitogen-hq#1110
Member
|
@jrosser I think https://github.com/moreati/mitogen/tree/unsafe-large-copy is ready for you to update your branch with. It turns out the test suite already had tests for large file copies, but they weren't inside a |
jrosser
force-pushed
the
unsafe-large-copy
branch
from
b5e9784 to
5af6534
Compare
jadacyrus
pushed a commit
to jadacyrus/mitogen
that referenced
this pull request
Jan 28, 2025
This is in anticipation of mitogen-hq#1110, which only exhibits inside a with_items: loop. For this refactor `loop:` is used, to confirm the refactored tests are still correct. A subsequent commit will change them to with_items. The content of the files and their SHA1 checksums are unchanged.
jadacyrus
pushed a commit
to jadacyrus/mitogen
that referenced
this pull request
Jan 28, 2025
The bug was fixed in a previous commit by Jonathan Rosser. This adds testing. The bug is only triggered when the copy module is used inside a `with_items:` loop and the destination filename has an extension. A `loop:` loop is not sufficient. refs mitogen-hq#1110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small files are carried in-band in the communication between controller and remote, with larger files being copied by falling back to
transfer_file(). This second code path was missed in b822f20.Reproducer extracted from original code that failed:
Make the files larger than 2^17 bytes to trigger a failure
Exception: