ci: Consolidate Mitogen jobs#1159
Merged
moreati merged 2 commits intomitogen-hq:masterfrom Oct 10, 2024
Merged
Conversation
moreati
force-pushed
the
test-distro-specs
branch
from
f97d7d3 to
f4a4062
Compare
moreati
force-pushed
the
test-distro-specs
branch
from
f4a4062 to
1f1ebed
Compare
This reduces the number of jobs from 48 to 24. The Mitogen part of the test suite has been parameterized on the Linux container targets to be run against. Both the Ansible tests & Mitogen tests now use the same source of truth to control which targets to use: environment variable MITOGEN_TEST_DISTRO_SPECS. This replaces the two mutually exclusive env vars DISTRO and DISTROS. I've also removed vestgial traces of an unused env var MITOGEN_TEST_DISTRO. Parameterization adapted from https://eli.thegreenplace.net/2014/04/02/dynamically-generating-python-test-cases refs mitogen-hq#1058, mitogen-hq#1059
moreati
force-pushed
the
test-distro-specs
branch
from
1f1ebed to
28e08ef
Compare
Member
Author
BeforeAfter |
moreati
added a commit
to mordekasg/mitogen
that referenced
this pull request
Oct 14, 2024
This reads the become username from the `become_user` attribute of the play context, to the `"become_user"` option of the loaded become plugin. This has been supported by vanilla Ansible since Ansible 2.10 (ansible-base 2.10). To support this I've also switched from using the `play_context.become` (a bool), to `connection.become` (an instance of the appropriate) become plugin. New tests have been added, modelled on those for templated connection parameters (see mitogen-hq#1147, mitogen-hq#1153, mitogen-hq#1159). See - ansible/ansible@480b106 refs mitogen-hq#1083 Co-authored-by: mordek <m.pirog@bonasoft.pl>
jadacyrus
pushed a commit
to jadacyrus/mitogen
that referenced
this pull request
Jan 28, 2025
This reads the become username from the `become_user` attribute of the play context, to the `"become_user"` option of the loaded become plugin. This has been supported by vanilla Ansible since Ansible 2.10 (ansible-base 2.10). To support this I've also switched from using the `play_context.become` (a bool), to `connection.become` (an instance of the appropriate) become plugin. New tests have been added, modelled on those for templated connection parameters (see mitogen-hq#1147, mitogen-hq#1153, mitogen-hq#1159). See - ansible/ansible@480b106 refs mitogen-hq#1083 Co-authored-by: mordek <m.pirog@bonasoft.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the number of jobs from 48 to 24. The Mitogen part of the test suite has been parameterized on the Linux container targets to be run against. Both the Ansible tests & Mitogen tests now use the same source of truth to control which targets to use: environment variable
MITOGEN_TEST_DISTRO_SPECS. This replaces the two mutually exclusive env varsDISTROandDISTROS. I've also removed vestgial traces of an unused env varMITOGEN_TEST_DISTRO.Parameterization adapted from https://eli.thegreenplace.net/2014/04/02/dynamically-generating-python-test-cases
refs #1058, #1059