Skip to content

[Enhancement] handle kubectl vars from Ansible connector. #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

Yannig
Copy link
Contributor

@Yannig Yannig commented Sep 20, 2018

This change allows the kubectl connector to support the same options as
Ansible's original connector.

The playbook sample comes with an example of a pod containing two containers
and checking that moving from one container to another, the version of Python
changes as expected.

self.username = username

_kubectl_options = []
for key, option in iteritems(ansible.plugins.connection.kubectl.CONNECTION_OPTIONS):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't import ansible from the core library. Otherwise this looks good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

This change allows the kubectl connector to support the same options as
Ansible's original connector.

The playbook sample comes with an example of a pod containing two containers
and checking that moving from one container to another, the version of Python
changes as expected.
@Yannig Yannig force-pushed the kubectl_enhancement branch from 0416665 to 17548d1 Compare October 2, 2018 09:54
@Yannig
Copy link
Contributor Author

Yannig commented Oct 2, 2018

@dw I tried to put everything specific to Ansible in the mitogen_ansible directory. I hope it will be OK :)

dw added a commit that referenced this pull request Oct 2, 2018
(Pull #377)

Changes:
- additional_parameters -> extra_args
- Merge with kubectl changes from dmw branch
- Update docs
- Remove unused username class member
- Avoid mutable kubectl_args class member
- Use six.iteritems
@dw dw merged commit 17548d1 into mitogen-hq:master Oct 2, 2018
PatrickCoakley23 pushed a commit to cyara/mitogen that referenced this pull request Nov 10, 2023
…lan_changes

removing the duplicate dialplan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants