[Enhancement] handle kubectl vars from Ansible connector. #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dw
reviewed
Oct 1, 2018
mitogen/kubectl.py
Outdated
| self.username = username | ||
|
|
||
| _kubectl_options = [] | ||
| for key, option in iteritems(ansible.plugins.connection.kubectl.CONNECTION_OPTIONS): |
There was a problem hiding this comment.
We can't import ansible from the core library. Otherwise this looks good!
This change allows the kubectl connector to support the same options as Ansible's original connector. The playbook sample comes with an example of a pod containing two containers and checking that moving from one container to another, the version of Python changes as expected.
Yannig
force-pushed
the
kubectl_enhancement
branch
from
0416665 to
17548d1
Compare
|
@dw I tried to put everything specific to Ansible in the mitogen_ansible directory. I hope it will be OK :) |
dw
added a commit
that referenced
this pull request
Oct 2, 2018
(Pull #377) Changes: - additional_parameters -> extra_args - Merge with kubectl changes from dmw branch - Update docs - Remove unused username class member - Avoid mutable kubectl_args class member - Use six.iteritems
PatrickCoakley23
pushed a commit
to cyara/mitogen
that referenced
this pull request
Nov 10, 2023
…lan_changes removing the duplicate dialplan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the kubectl connector to support the same options as
Ansible's original connector.
The playbook sample comes with an example of a pod containing two containers
and checking that moving from one container to another, the version of Python
changes as expected.