tests: Correct DISTRO vs DISTROS usage in CI configurations #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variable DISTRO is used to set the target Docker image used when running the Mitogen unit tests. DISTROS is used for the Ansible integration tests. VER sets the version of Ansible that is installed on the controller. When MODE=Mitogen - there is no need to set VER, because nothing that installs Ansible - it does not make sense to set DISTROS.
s1113950
approved these changes
Jan 11, 2021
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
s1113950
reviewed
Feb 7, 2021
| @@ -217,9 +217,12 @@ def __exit__(self, _1, _2, _3): | |||
|
|
|||
| os.environ.setdefault('ANSIBLE_STRATEGY', | |||
| os.environ.get('STRATEGY', 'mitogen_linear')) | |||
| # Ignoreed when MODE=mitogen | |||
There was a problem hiding this comment.
typo, but not enough to warrant delaying this imo
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable
DISTROis used to set the target Docker imageused when running the Mitogen unit tests.
DISTROSis used for theAnsible integration tests.
VERsets the version of Ansible that isinstalled on the controller.
When
MODE=MitogenVER, because nothing that installs AnsibleDISTROS.