Don't handle every array item within each array item - #4480
Merged
Conversation
In handleArray, the array v is looped over. For each item, the entire array is looped over again, resulting in an array v of length n resulting in an output array of length n^2, making handleArray's complexity O(n^2). However, that n^2 looping is unnecessary. Removing it brings the complexity of handleArray down to O(n), drastically reducing execution time.
Contributor
Author
… of the spurious results either cause they're not there in the first place - this should also speed up processing since we don't need to do a jillion searches Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
…dn't realize - the original zap sample has a duplicate subfinding for some reason and we were removing it from our results through the dedupe process. now it's put back and correctly reflects the original file Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Amndeep7
approved these changes
May 23, 2023
Amndeep7
left a comment
Amndeep7
left a comment
Contributor
There was a problem hiding this comment.
Excellent catch. Extended the implication from where you found savings with my own commits.
Amndeep7
added
the
ready-to-merge
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In handleArray, the array v is looped over. For each item, the entire array is looped over again, resulting in an array v of length n resulting in an output array of length n^2, making handleArray's complexity O(n^2).
However, that n^2 looping is unnecessary. Removing it brings the complexity of handleArray down to O(n), drastically reducing execution time.