Feature/iam 9 convert upstream to spring boot #1067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…://git.enovation.nl/scm/iam/openid-connect-java-spring-server into feature/IAM-9-convert-upstream-to-spring-boot # By Albert van 't Hart # Via Albert van 't Hart * 'feature/IAM-9-convert-upstream-to-spring-boot' of https://git.enovation.nl/scm/iam/openid-connect-java-spring-server: IAM-9 added profile id and version range
|
Very cool! I'm a little concerned of the duplication of code between this and the -webapp module, is there any way we can pull these in? I think we'll target this for development in 1.3. |
|
How do we implement the principle of overlays with Spring Boot? Or will we simply keep building to WAR files? |
|
|
||
| // TODO what's exaclty the difference between, taskScheduler and taskExecutor? | ||
|
|
||
| @Scheduled(fixedDelay = 30000, initialDelay = 60000) |
There was a problem hiding this comment.
Shouldn't this use something like fixedDelayString = "${openid.connect.server.scheduler.token.fixedDelay}" same for initial
|
Hello folks, What is the current status of the spring boot migration? Still planning to merge this in the 1.3 branch/master branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.