Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed bug in models_commited behavior. #78

wants to merge 2 commits into


None yet
3 participants

If multiple instances from different models added to session and committed, any PK overlap among models will cause collisions and only one instance per PK gets sent to models_committed.

Updated test suite to capture new behavior.

gyllstromk added some commits May 25, 2012

@gyllstromk gyllstromk Some slight rewording. 0a44a4f
@gyllstromk gyllstromk Fixed bug in ``models_committed``. The problem is that _model_changes
was a PK->change dict, which means that if two different models were
created with the same PK, the change would be overwritten and only one
model per PK would be sent to the before_models_committed/models_committed handlers.
_model_changes is now a 2-level dict model_class->PK->changes, which
solved the problem.

The test case ``test_model_signals`` was updated; it fails on the old
version and passes on the new.

immunda commented Apr 2, 2015

Fixed in master, soon to be released in 2.1

@immunda immunda closed this Apr 2, 2015

@davidism davidism added this to the 2.1 milestone Jan 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment