Fix before_models_committed signal #95

Closed
wants to merge 2 commits into
from

Projects

None yet

5 participants

@insom
insom commented Aug 8, 2012

As per #90 - I'm seeing the same thing; the signal never fires because d is always empty when it does. I originally added before_{insert,update,delete} event handlers, but it looks like before_commit fires before even they do.

The approach on this pull request is to introspect the session object and see what is queued to be committed. I've included tests done by @DazWorrall which originally failed but now pass and I believe cover what the documentation says this signal should do.

@tonymillion

Yep I'm seeing this too,models_committed is firing, before_models_committed is not.

@mitsuhiko any chance of accepting this patch?

@immunda
Collaborator
immunda commented Jan 6, 2015

This is better addressed in #150

@immunda immunda closed this Jan 6, 2015
@davidism davidism added this to the 2.1 milestone Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment