Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Do not use Date, use Last-Modified. This fixes #164

  • Loading branch information...
commit 0bf777ed81d5296fb722931d35e5db4333e3de39 1 parent 94f90bc
@mitsuhiko authored
Showing with 4 additions and 6 deletions.
  1. +2 −0  CHANGES
  2. +2 −6 flask/helpers.py
View
2  CHANGES
@@ -33,6 +33,8 @@ Release date to be announced, codename to be selected
- Added an `endpoint` method to the flask application object which
allows one to register a callback to an arbitrary endpoint with
a decorator.
+- Use Last-Modified for static file sending instead of Date which
+ was incorrectly introduced in 0.6.
Version 0.6.1
-------------
View
8 flask/helpers.py
@@ -364,13 +364,9 @@ def send_file(filename_or_fp, mimetype=None, as_attachment=False,
direct_passthrough=True)
# if we know the file modification date, we can store it as the
- # current time to better support conditional requests. Werkzeug
- # as of 0.6.1 will override this value however in the conditional
- # response with the current time. This will be fixed in Werkzeug
- # with a new release, however many WSGI servers will still emit
- # a separate date header.
+ # the time of the last modification.
if mtime is not None:
- rv.date = int(mtime)
+ rv.last_modified = int(mtime)
rv.cache_control.public = True
if cache_timeout:
Please sign in to comment.
Something went wrong with that request. Please try again.