Minor test fixes #862
Merged
Minor test fixes #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2013 18:21
Path in assertion is now cross-platform.
static/index.html now opens in binary mode, and therefore newline conversion does not take place.
|
✨ 🍰 ✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_no_error_swallowingthe path is hardcoded as'flask_broken/__init__.py', however on Windowsco_filenamewill return'flask_broken\\__init__.py', and so the assertion will fail. The fix usesos.path.jointo generate a path suitable for the current system.test_send_file_objectthe file is first opened in text mode, which converts newlines to\n. However, later on the same file is opened in binary mode usingapp.open_resource, and so newlines are not converted. On Windows this leads to a failing test because Git converts all newlines to\r\non checkout. Basically, when opening in text mode we get\nnewlines, and when opening in binary mode we get\r\nnewlines. The fix solves this by opening the file in binary mode the first time, as well.