Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest cargo insta test when running cargo test #223

Closed
max-sixty opened this issue Mar 26, 2022 · 2 comments
Closed

Suggest cargo insta test when running cargo test #223

max-sixty opened this issue Mar 26, 2022 · 2 comments

Comments

@max-sixty
Copy link
Collaborator

We're using insta a lot in PRQL.

A core dev wanted to split up the tests, because they were finding only the first test was replaced https://github.com/max-sixty/prql/pull/261. They had been running cargo test rather than cargo insta test.

Would it be helpful to add a comment to the "To update snapshots run cargo insta review" message that's printed to also say something like "Stopped on the first failure in {func}. Run cargo insta test to run all snapshots."

I can also write a "Contributing" guide which includes this for PRQL, but even better if it's upstreamed.

I'm happy to do a PR.

@mitsuhiko
Copy link
Owner

Fixed in d80987d. Good idea thanks!

@max-sixty
Copy link
Collaborator Author

Thanks a lot @mitsuhiko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants