Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using --target in new arg forwarding #309

Closed
max-sixty opened this issue Dec 2, 2022 · 1 comment
Closed

Using --target in new arg forwarding #309

max-sixty opened this issue Dec 2, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@max-sixty
Copy link
Collaborator

What happened?

Thanks a lot for the changes from #301.

Almost everything works, but I'm not sure how to pass --target. Specifically:

  • It seems that -p and --lib need to go before the --, and then other items go after; e.g. from 0.21.0 to 0.21.2:
    -cargo insta test --accept -- -p mdbook-prql run_examples
    +cargo insta test --accept -p mdbook-prql -- run_examples
  • But I can't get cargo insta test --accept -- --target=wasm32-unknown-unknown to work, with --target either before the -- or after. (after two -- doesn't raise an error but also doesn't seem to do anything)
      Finished test [unoptimized + debuginfo] target(s) in 0.36s
       Running unittests src/main.rs (target/debug/deps/mdbook_prql-c1048722bc7cd3a6)
    error: Unrecognized option: 'target'
    

(ref PRQL/prql#1172)

Sorry if this is a pain...

Reproduction steps

No response

Insta Version

0.21.2

rustc Version

rustc 1.64.0 (a55dd71d5 2022-09-19)

What did you expect?

No response

@max-sixty max-sixty added the bug Something isn't working label Dec 2, 2022
@max-sixty
Copy link
Collaborator Author

Thank you @mitsuhiko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant