Fix backward compatibility with TOML format produced by insta < 1.45.0#849
Merged
max-sixty merged 2 commits intomitsuhiko:masterfrom Dec 29, 2025
Merged
Fix backward compatibility with TOML format produced by insta < 1.45.0#849max-sixty merged 2 commits intomitsuhiko:masterfrom
max-sixty merged 2 commits intomitsuhiko:masterfrom
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
thank you very much @chitoku-k! I think you're correct; apologies for releasing the backward-incompat code... |
Merged
max-sixty
added a commit
that referenced
this pull request
Dec 29, 2025
## Summary - Bumps version to 1.45.1 - Updates CHANGELOG with the fix from #849 ## Changes - Fix backward compatibility with TOML format produced by insta < 1.45.0. #849 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes backward compatibility with insta < 1.45.0 that has been broken since #834.
As far as I tested, the tests that were added in #834 did not match the behavior before insta 1.45.0 and simply produced new behavior. I tried to fix the implementation as long as test cases and ensured it locally by adding back
toml 0.5.7and temporarily reverting back totoml::to_string_pretty(&content)to test if it matches the original behavior except for those that panicked before, which does not break compatibility at all.