Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnection on async connection #294

Closed
nazar-pc opened this issue Mar 17, 2020 · 1 comment
Closed

Reconnection on async connection #294

nazar-pc opened this issue Mar 17, 2020 · 1 comment

Comments

@nazar-pc
Copy link

@nazar-pc nazar-pc commented Mar 17, 2020

I'd like to say that current design with missing reconnection is quite painful to work with in production.
It would bring usability to the next level if library has detection for disconnection and re-connects automatically if possible.

I've used async connection, but when Redis server disconnects, calling command like zadd does... nothing... forever.
I need to wrap it in cancelable future, add timeouts handing on top myself and handle reconnections in some way, which at the end is not friendly at all.

Coming from TypeScript background, this is such an obvious feature to have, please consider implementing it. Something like a builder pattern where timeouts can be specified and reconnection configured would be the best.

This is probably related to #218

@nazar-pc

This comment has been minimized.

Copy link
Author

@nazar-pc nazar-pc commented Mar 18, 2020

I think this is basically the same as #295, async API failed completely for me because of various reasons.

@nazar-pc nazar-pc closed this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.