Merge pull request voldemort#85 from pbailis/master

Enable log4j.properties in all tests and fix hidden debug NPE
mitultiwari · Aug 1, 2012 · b8f0be4 · b8f0be4
2 parents d15b605 + 2c6b61f
commit b8f0be4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/build.properties b/build.properties
@@ -36,8 +36,5 @@ tomcat.manager.username=tomcat
 tomcat.manager.password=tomcat
 tomcat.context=/voldemort
 
-## Log4j
-log4j.properties.dir=src/java
-
 ## Release
 curr.release=0.90.1
diff --git a/build.xml b/build.xml
@@ -27,6 +27,7 @@
   </condition>
 
   <path id="contrib-classpath">
+    <pathelement path="${resources.dir}" />
     <fileset dir="${dist.dir}">
       <include name="${name}-${curr.release}.jar" />
     </fileset>
@@ -37,6 +38,7 @@
   </path>
 
   <path id="test-classpath">
+    <pathelement path="${resources.dir}" />
     <pathelement path="${env.VOLD_TEST_JARS}" />
     <path refid="main-classpath" />
     <pathelement path="${testclasses.dir}" />
@@ -372,7 +374,6 @@
     <replace-dir dir="${testhtml.dir}" />
     <junit printsummary="yes" showoutput="true" maxmemory="1024m">
       <classpath refid="test-classpath" />
-      <classpath path="${log4j.properties.dir}" />
       <formatter type="xml" />
       <batchtest fork="yes" todir="${testreport.dir}">
         <fileset dir="${unittestsrc.dir}">

diff --git a/src/java/voldemort/store/socket/SocketStore.java b/src/java/voldemort/store/socket/SocketStore.java
@@ -445,7 +445,7 @@ private void invokeCallback(Object o, long requestTime) {
                                      + clientRequestExecutor.getSocketChannel()
                                                             .socket()
                                                             .getLocalPort() + " result: "
-                                     + o.toString());
+                                     + o);
                     }
 
                     callback.requestComplete(o, requestTime);