Add --use-official-installer, fix official installer download after update 4.9 #906
Conversation
…m64 for linux and windows
|
The installer names seems to have been changed on the Qt repo. I wrote a better way to parse them, and added support for arm64 for windows and linux. |
Kidev
changed the title
Kidev
changed the title
|
|
||
|
|
||
| def extract_auth(args: List[str]) -> Tuple[str | None, str | None, List[str] | None]: | ||
| def extract_auth(args: List[str]) -> Tuple[Union[str, None], Union[str, None], Union[List[str], None]]: |
| return actual.startswith(prefix + expected[0]) and actual.endswith(expected[1]) | ||
| return actual.startswith(expected[0]) and actual.endswith(expected[1]) | ||
| return actual.startswith(prefix + expected) | ||
| return actual.startswith(expected) |
There was a problem hiding this comment.
This might be a bit extreme, but, considering all of this is generated, and that it always creates errors in the test suite that I'm unable to fix on both my PC and the CI (???), I figured maybe just checking for the start to be the help string may be enough
It is the cause of the failure of the current CI run by the way. This fixes it
| Version: 6.8.1 | ||
| Components: qt.tools.qtcreator_gui,qt.tools.cmake,qt.tools.ninja | ||
| Required aliases: qt6.8.1-full-dev,qt6.8.1-full-dbg | ||
There was a problem hiding this comment.
Was not displayed in the docs, as dropdown is not a thing in .rst. Moreover there is a link to the Qt website with this data somewhere else in the page
| if not temp_path.exists(): | ||
| temp_path.mkdir(parents=True, exist_ok=True) | ||
| else: | ||
| Settings.qt_installer_cleanup() |
There was a problem hiding this comment.
Similar pattern appears 3 or 4 times in the code. I replaced the erasing of the aqt/tmp directory by the removal of its content instead. This make testing for the existence of files in the test suite much easier, as well as making the check for permissions easy by providing an existing folder in the file system of the user
This PR:
--use-official-installeroption toinstall-qt, enabling a straight forward way to use the official installer while still using the standard install command.--use-official-installeroptionauthors.rstandofficial.rstto fix mistakes in the documentation (warnings reported by Codacy)use-official-installeroption--use-official-installer [email pw]If used, this will ignore your
hostparameter, and use the current OS (Qt restriction). You can use it without any parameter if you already signed in (so if you have a qtaccount.ini valid for the current user). Otherwise, you need to provide an email and a password: